Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow Counts #1686

Merged
merged 23 commits into from
Oct 16, 2023
Merged

Workflow Counts #1686

merged 23 commits into from
Oct 16, 2023

Conversation

Alex-Tideman
Copy link
Contributor

@Alex-Tideman Alex-Tideman commented Oct 13, 2023

Description & motivation 💭

Screenshots (if applicable) 📸

Screen Shot 2023-10-13 at 11 56 57 AM

Design Considerations 🎨

Testing 🧪

How was this tested 👻

  • Manual testing
  • E2E tests added
  • Unit tests added

Steps for others to test: 🚶🏽‍♂️🚶🏽‍♀️

Checklists

Draft Checklist

Merge Checklist

  • Need to check and add support for system-info endpoint in cloud

Issue(s) closed

Docs

Any docs updates needed?

@vercel
Copy link

vercel bot commented Oct 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
holocene ⬜️ Ignored (Inspect) Visit Preview Oct 16, 2023 4:03pm

Copy link
Contributor

@rossedfort rossedfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for 1 comment on moving the API logic into a service

src/lib/components/workflow/workflow-counts.svelte Outdated Show resolved Hide resolved
Comment on lines +29 to +31
}).then((systemInformation) => {
return systemInformation;
});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: this is redundant, can just return requestFromApi(route { request });

@Alex-Tideman Alex-Tideman merged commit 03135e2 into main Oct 16, 2023
9 checks passed
@Alex-Tideman Alex-Tideman deleted the workflow-counts branch October 16, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants